There are literally hundreds. But what makes a great war film, to me its atmosphere. Do you end up with the feel of the time, and is that feel accurate. Also, does the movie look right. It can be getting the vehicles, uniforms, weapons right. And is it a good story. Do you feel for the people. Once past all of these historical accuracy is also great. So, having said all of these, here are my favorites.
1. Waterloo. Sergei Bondachuck's film is still the gold standard.
2. The Iron Cross. Sam Peckenpau does Willi Heinrich's film justice.
3. Saving Private Ryan. Leaves you feeling like you're in the middle of the battle.
1. Enemy at the Gates. Stalingrad, snipers, T34's and pretty good attempts at Mk III's. Has nothing to do with the actual story but hey, the opening scene is great.
2. Bridge Too Far. Was my favorite for a long time, but other films moved in.
3. Band of Brothers, not a movie, but a great program.
4. Wind and the Lion. Has nothing to do with history, but such a great film
5. Gettysburg. Historically correct, well shot, except for the incredibly overweight picket in the Army of Northern Virginia, and overall a great film.